Improve support for tramp source buffers #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (when (tramp-tramp-file-p jump-origin) | ||
| (let ((vec (tramp-dissect-file-name jump-origin))) | ||
| (defun cider-tramp-prefix (&optional buffer) | ||
| "Use the current buffer to determine Clojure host." |
There was a problem hiding this comment.
You should mention BUFFER in the docstring.
|
Overall the changes look good. You should also document them in the changelog, since they are noteworthy. |
Ensures load-file doesn't use the tramp location of the file for the filename passed to the nrepl load-file op (which gets compiled into debug information). This caused some issues when using the same repl with source files both locally and over tramp. Uses an explicit buffer to determine the tramp prefix rather than the find-tag-marker-ring. Changes the signature of cider-jump-to-def-for to add a buffer argument. Changes cider-jump-to-def-for to look for a tramp path before a local path.
| (let ((vec (tramp-dissect-file-name jump-origin))) | ||
| (defun cider-tramp-prefix (&optional buffer) | ||
| "Use the filename for BUFFER to determine a tramp prefix. | ||
| Defaults to the current buffer. |
There was a problem hiding this comment.
Emacs Lisp docstrings differ from Clojure's - you shouldn't add leading whitespace after the first line. I noticed this in your other PR as well.
|
👍 |
bbatsov
added a commit
that referenced
this pull request
Mar 2, 2014
Improve support for tramp source buffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures load file doesn't use the tramp location of the file for the filename
passed to the nrepl load-file op. This caused some issues when using the same
repl and source files both locally and over tramp.
Uses an explicit buffer to determine the tramp prefix rather than the
find-tag-marker-ring. Changes the signature of cider-jump-to-def-for to add a
buffer argument.
Changes cider-jump-to-def-for to look for a tramp path before a local
path.