Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider-repl font-lock issue #824

Closed
luxbock opened this issue Sep 23, 2014 · 7 comments
Closed

cider-repl font-lock issue #824

luxbock opened this issue Sep 23, 2014 · 7 comments
Milestone

Comments

@luxbock
Copy link

luxbock commented Sep 23, 2014

After a recent upgrade I noticed that font-locking for the prompt fails by coloring the text inserted as well, unless the text starts with a parentheses like character. In the case of anonymous functions and sets, the hash-tag character is also colored. If I cycle input from the history of typed commands, then those commands are always colored with the prompt font as well.

@bbatsov
Copy link
Member

bbatsov commented Oct 3, 2014

Yeah, I noticed this myself. I'll have a closer look at the problem soon.

@turtle-bazon
Copy link

Problem still persists. Updated cider yesterday.

@turtle-bazon
Copy link

Also I can say that font locking in repl completely broken. Only parentheses colored as needed.

@bbatsov
Copy link
Member

bbatsov commented Oct 15, 2014

I'm aware of that, but don't have any time to deal with this right now. Help welcome! :-)

@bbatsov
Copy link
Member

bbatsov commented Oct 15, 2014

A bit more info regarding this issue:

The problem is here. Replacing font-lock-face with face fixes it, but breaks related modes like rainbow-delimiters. See #749 for more details.

@vspinu
Copy link
Contributor

vspinu commented Oct 15, 2014

The whole font-lock mechanism should be changed to use standard jit-lock fontification. I have plans for that after cider-repl is re-planted on comint-mode. There is little point to play with font-lock before comint is sorted out. Unfortunately I am not likely to have time for that till the end of November. There are also other, more critical, issues waiting to be sorted out in meanwhile.

@bbatsov
Copy link
Member

bbatsov commented Nov 30, 2014

Fixed by 48fceed

@bbatsov bbatsov closed this as completed Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants