Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment-start not defined #888

Closed
mwfogleman opened this issue Nov 22, 2014 · 3 comments
Closed

comment-start not defined #888

mwfogleman opened this issue Nov 22, 2014 · 3 comments

Comments

@mwfogleman
Copy link

cider-repl does not have the mode-local variable comment-start defined. In modes that do not have comment-start defined, newcomment.el will sometimes request (by way of comment-normalize-vars) that you input one by read-string.

Can we define it in cider-repl, like we do in cider-nrepl?

@mwfogleman
Copy link
Author

Thanks for working to solve this issue. However, repl-mode still does not have comment-start defined.

@bbatsov
Copy link
Member

bbatsov commented Nov 30, 2014

Guess you're not using the latest version or something. comment-start comes from lisp-mode-variables. I've played with this and it definitely works for me.

@mwfogleman
Copy link
Author

Sorry for the noise, and thanks for the fix. I updated with MELPA, but it must not have been a version that had the fix yet.

Trying a version with the fix now and all is well, as you suspected. Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants