Skip to content

Parameterise whether require ns use :refer all or :as sut when creating namespace form #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yatesco opened this issue Aug 27, 2015 · 2 comments

Comments

@yatesco
Copy link

yatesco commented Aug 27, 2015

At the moment the automatically generated :require statement pulls in the subject under test as [a.b.c :refer :all]. I, and I think a bunch of people would prefer [a.b.c :as sut].

Would be great if cider exposed a var which either:

  • toggled between the two (e.g. cider-pull-su-as-refer-all)
  • provided a template for the require form (e.g. (setq cider-sut-require-form "[:refer % :as sut]"))

I dunno - I am an emacs newbie, but hopefully the intent of this issue is clear.

Thanks!

@expez
Copy link
Member

expez commented Aug 27, 2015

I'd prefer just making this the new default because there is no :refer :all in cljs and it's kind of considered a bad practice as it is. What do you guys think @benedekfazekas @magnars?

@expez
Copy link
Member

expez commented Aug 29, 2015

Seems I messed up the issue reference, but this is fixed in 98f1013

@expez expez closed this as completed Aug 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants