[inspector] Handle InaccessibleObjectException for foreign-module fields #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
inaccessible-exception
branch
2 times, most recently
from
035afaa
to
598f621
Compare
bbatsov
reviewed
Dec 24, 2019
src/orchard/inspect.clj
Outdated
| (catch Exception e | ||
| ;; We want to handle specifically SecurityException | ||
| ;; and j.l.r.InaccessibleObjectException, but the | ||
| ;; letter only comes with Java9+, so let's just |
|
Btw, please mention this in the changelog as well. |
alexander-yakushev
force-pushed
the
inaccessible-exception
branch
from
598f621
to
4da9776
Compare
|
So, is it good enough now? |
|
Yep. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Java9+, when trying to inspect an object of a class that comes from the other module, and that object has private fields, JVM will throw InaccessibleObjectException when the inspector tries to set those private fields to accessible. Unfortunately, there doesn't seem a generic way to work around this, so at least we want the inspector to not crash in such situations.
Here's what the inspector shows after the patch: