Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugin into separate packages #64

Merged
merged 11 commits into from
Nov 28, 2021

Conversation

bourdakos1
Copy link
Member

@bourdakos1 bourdakos1 commented Nov 25, 2021

Expected breaking changes:

plugins[]corsProxy -> themeConfig.proxy

plugins[]openapiPath -> plugins[]path // optional with default of "openapi.json"

creates a preset that can replace @docusaurus/preset-classic

TODO:

  • Rename corsProxy to proxy
  • Move proxy to themeConfig since it's theme specific
  • Use JOI to handle config validation
  • Change openapiPath to path
  • Make path optional with a sensible default
  • path should be relative to site dir, not absolute using require.resolve()
  • Update dependencies

@bourdakos1 bourdakos1 marked this pull request as ready for review November 28, 2021 21:09
@bourdakos1 bourdakos1 merged commit d39424f into cloud-annotations:master Nov 28, 2021
@bourdakos1 bourdakos1 deleted the split-packages branch November 28, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant