Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance NLB mgmt feature #1161

Closed
jihoon-seo opened this issue Aug 30, 2022 · 5 comments · Fixed by #1175, #1178, #1172, #1193 or #1194
Closed

Enhance NLB mgmt feature #1161

jihoon-seo opened this issue Aug 30, 2022 · 5 comments · Fixed by #1175, #1178, #1172, #1193 or #1194
Assignees
Labels
feature request Issue related with new feature

Comments

@jihoon-seo
Copy link
Member

jihoon-seo commented Aug 30, 2022

What would you like to be added
:

'Add/Remove VM to/from NLB' feature → Resolved in #1175

Why is this needed
:

@jihoon-seo jihoon-seo added the feature request Issue related with new feature label Aug 30, 2022
@jihoon-seo jihoon-seo self-assigned this Aug 30, 2022
@jihoon-seo
Copy link
Member Author

jihoon-seo commented Aug 30, 2022

Rename field: vmGroup -> targetGroup → Resolved in #1175

@jihoon-seo
Copy link
Member Author

Add some APIs (healthCheck, ...)

@jihoon-seo jihoon-seo changed the title 'Add/Remove VM to/from NLB' feature Enhance NLB mgmt feature Sep 20, 2022
@jihoon-seo
Copy link
Member Author

[Key hierarchy of TB objects]

[As-is]

    "/ns/ns01/mcis/jhseo",
    "/ns/ns01/mcis/jhseo/vm/openstack-region01-0",
    "/ns/ns01/mcis/jhseo/vm/openstack-region01-1",
    "/ns/ns01/mcis/jhseo/vmgroup/openstack-region01",
    "/ns/ns01/nlb/openstack-region01-jhseo",

[To-be]

    "/ns/ns01/mcis/jhseo",
    "/ns/ns01/mcis/jhseo/vm/openstack-region01-0",
    "/ns/ns01/mcis/jhseo/vm/openstack-region01-1",

    "/ns/ns01/mcis/jhseo/nlb/openstack-region01-jhseo",

@jihoon-seo
Copy link
Member Author

[As-is]
Create NLB 시, 사용자가 다음을 명시

  • MCIS ID (string)
  • 해당 MCIS에 속하는 VM 중, NLB backend로 추가할 VM들의 ID들 ([]string)

[To-be]
Create NLB 시, 사용자가 다음을 명시

  • MCIS ID (string)
  • 해당 MCIS에 속하는 vmGroup 중, NLB backend로 추가할 VM들을 포함하는 vmGroup의 ID (string)
  • addVMtoNLB(), removeVMfromNLB(): 사용자 API는 삭제하고, 내부에서만 활용하는 함수로 변경
    (MCIS vmGroup에 VM 추가/삭제 시, 위의 두 함수를 내부적으로 호출하여 NLB에서도 VM 추가/삭제)

@jihoon-seo jihoon-seo linked a pull request Sep 20, 2022 that will close this issue
@seokho-son
Copy link
Member

// addVMtoNLB(), removeVMfromNLB(): 사용자 API는 삭제하고, 내부에서만 활용하는 함수로 변경
// (MCIS vmGroup에 VM 추가/삭제 시, 위의 두 함수를 내부적으로 호출하여 NLB에서도 VM 추가/삭제)

@jihoon-seo 일단 이미 만들어져있니, 삭제하지 않고 api에서 disable 하거나 deprecate 시켜두는 것이 좋겠죠? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment