Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Graceful Shutdown of CB-Tumblebug server #716

Closed
seokho-son opened this issue Sep 8, 2021 · 4 comments · Fixed by #874
Closed

Add Graceful Shutdown of CB-Tumblebug server #716

seokho-son opened this issue Sep 8, 2021 · 4 comments · Fixed by #874
Assignees
Labels
feature request Issue related with new feature help wanted Extra attention is needed

Comments

@seokho-son
Copy link
Member

What would you like to be added
: Graceful Shutdown of CB-Tumblebug server (REST API, ...)

Why is this needed

Whenever a server needs to shut down for various reasons, the common one being OS interrupts, we would want our servers to shut down gracefully. We would want our golang server to stop receiving new requests while complete the ongoing requests and return their responses and then finally shut down. - "Graceful shutdown of Golang servers using Context and OS signals" by Pinku Deb Nath

ref) https://echo.labstack.com/cookbook/graceful-shutdown/
ref) https://medium.com/@pinkudebnath/graceful-shutdown-of-golang-servers-using-context-and-os-signals-cc1fa2c55e97

@seokho-son seokho-son added help wanted Extra attention is needed feature request Issue related with new feature labels Sep 8, 2021
@sypark9646
Copy link
Member

제가 해당 task 진행해보겠습니다!

@seokho-son
Copy link
Member Author

/assign @sypark9646

@seokho-son
Copy link
Member Author

감사 감사합니다~~ :)

@yunkon-kim
Copy link
Member

개선 사항이 있어 Reopen 하였습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue related with new feature help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants