Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Node on Pages" provides incorrect information on how builds work #2551

Open
1 task
drewbo opened this issue Oct 11, 2024 · 0 comments
Open
1 task

"Node on Pages" provides incorrect information on how builds work #2551

drewbo opened this issue Oct 11, 2024 · 0 comments

Comments

@drewbo
Copy link
Contributor

drewbo commented Oct 11, 2024

Our documentation provides conflicting information on how node dependencies are handled:

...the Pages build engine will check for a package.json file. If it finds one, it will install npm dependencies...

and

Pages runs npm ci which means: Your project must have a package-lock.json file

We actually won't run the install unless the lock file is present (https://github.com/cloud-gov/pages-build-container/blob/main/src/steps/build.py#L188-L207). It's possible this logic (which is notably a bit sloppy as written) was changed during the caching implementation

Notes

Acceptance Criteria

  • Determine next steps and acceptance criteria
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant