-
Notifications
You must be signed in to change notification settings - Fork 271
Add binary install directory #137
Add binary install directory #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a conscious decision to not provide such option in any of ansible role located in @cloudalchemy. /usr/local/bin
is the correct place for those binaries and it strictly adheres to man hier(7)
.
What is the reasoning behind providing this as a feature?
The main reason is that in the cluster I'm working with the /usr/local/bin is a mounted directory which I don't have permissions to change. I'm aware that the correct hierarchy resides on /usr/local/bin that manner I keep the default as it is. I don't mean to change the default behaviour. Just make it customizable. |
Binaries are currently droped in /usr/local/bin This commit add `node_exporter_binary_install_dir` variable where user can change the binary destination to `/opt/bin` for example.
e30b2aa
to
07d7b4a
Compare
After I merged it, I remembered one problem with this approach here and in previous designs. Always someone proposed to include a task responsible for creating a directory where node_exporter binary would be placed. This, in turn, had huge impact on managing directory permissions in default installations as we are by default making this role responsible for managing ansible-node-exporter/tasks/install.yml Lines 2 to 7 in d08e7c2
This task will be removed in future PR and if anyone wants to create a directory, then he/she needs to do it on a playbook level as managing system directories is out of scope for this role. |
By default node_exporter binary is placed in `/usr/local/bin` which causes removed task to manage this directory. Such "feature" is out of scope of this role and can cause problems in some deployment scenarios.\ This is a follow-up to #137
By default node_exporter binary is placed in `/usr/local/bin` which causes removed task to manage this directory. Such "feature" is out of scope of this role and can cause problems in some deployment scenarios.\ This is a follow-up to #137
Binaries are currently droped in /usr/local/bin
This commit add
node_exporter_binary_install_dir
variable where user canchange the binary destination to
/opt/bin
for example.