Add quotes to node_exporter parametrs in systemd service

[ruzickap]

Add quotes to node_exporter parametrs in systemd service.

When using the code like:

    - role: cloudalchemy.node-exporter
      node_exporter_enabled_collectors:
        - diskstats:
            ignored-devices: "^(ram|loop|fd)\\d+$"

Currently the systemd template for node_exporter looks:

# grep -A2 'ExecStart=' /etc/systemd/system/node_exporter.service
ExecStart=/usr/local/bin/node_exporter \
--collector.diskstats \
    --collector.diskstats.ignored-devices=^(ram|loop|fd)\d+$ \

Which is wrong. That's why created this PR which is adding quotes to do it properly:

ExecStart=/usr/local/bin/node_exporter \
--collector.diskstats \
    --collector.diskstats.ignored-devices="^(ram|loop|fd)\d+$" \

[cmoetzing]

I am not sure if this problem is really fixed.
The line --collector.{{ name }}.{{ k }}={{ v }} \ was change but the error is in line --collector.{{ name }} \
Since I am still facing the problem I changed {% set name, options = (collector.items()|list)[0] -%} to {% set name, options = (collector.items()|list)[0] %} and that seems to fix the problem (removed the - at the end).
I have no idea what my change means. 😄

[downspot]

Any chance in getting this bug opened back up it's not working as described. I used the fix by @cmoetzing which is working.