Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

Set telemetry_path in yaml #196

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Set telemetry_path in yaml #196

merged 2 commits into from
Dec 14, 2020

Conversation

kmille
Copy link
Contributor

@kmille kmille commented Dec 14, 2020

Allows to set node_exporter_telemetry_path: /my/endpoint as variable to get --web.telemetry-path=/my/endpoint as command line parameter for the node_exporter.

Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Could you also add an entry in README.md?

defaults/main.yml Outdated Show resolved Hide resolved
templates/node_exporter.service.j2 Outdated Show resolved Hide resolved
@github-actions github-actions bot added area/jinja Templates area/vars Ansible variables used in role labels Dec 14, 2020
@github-actions github-actions bot added the area/docs Improvements or additions to documentation label Dec 14, 2020
@kmille
Copy link
Contributor Author

kmille commented Dec 14, 2020

I'm confused. Should be OK now from my side?

@paulfantom
Copy link
Member

Yes, this is good to go. It seems we had an issue with CI after migration to circleCI.

Thanks! 💯

@paulfantom paulfantom merged commit a646a04 into cloudalchemy:master Dec 14, 2020
@kmille
Copy link
Contributor Author

kmille commented Dec 17, 2020

@paulfantom can you please publish a 0.22.1 release? Otherwise I won't get the changes via ansible-galaxy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Improvements or additions to documentation area/jinja Templates area/vars Ansible variables used in role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants