-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Comparisons with RegEx #4
Comments
Hi, @hugobessa ! Anyway, there were no plans to support RegEx. For me it's hard to imagine cases, when RegEx search is an optimal solution for an API filter, do you have some? Team @zzzevaka, @marcserrat, @ffaraoneim, what do you think? |
@maxipavlovic you are right, regex syntax is DB dependent, it would be strange that an API consumer would know the DB engine behind the API. But for lib-rql perhaps it makes sense. What do you think? |
I see your point @ffaraoneim. I like the idea of support for filtering by Python regex in Python part. |
In theory, the |
What I mean is that it would make sense for lib-rql but also for django-rql |
Frankly speaking, personally I wouldn't want to expand this further than python version only, as we are also thinking of adding parsing to https://github.com/cloudblue/javascript-rql and regular expressions seem to be different in Python / JS, at least according to this and somehow they could affect grammar. IMHO, LIKE functionality seems to cover most of the cases in Django-RQL. |
@hugobessa CLA is now ready and automated :) |
Are there plans to support Comparisons with RegEx? Are PRs introducing this feature welcome?
The text was updated successfully, but these errors were encountered: