Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor script with UMD makes require complain #73

Closed
lukeapage opened this issue Mar 2, 2015 · 2 comments
Closed

Vendor script with UMD makes require complain #73

lukeapage opened this issue Mar 2, 2015 · 2 comments

Comments

@lukeapage
Copy link
Contributor

Hi,

I am trying to include es5-shim into my test runner page.

Because you load require before vendor (https://github.com/cloudchen/grunt-template-jasmine-requirejs/blob/master/src/templates/jasmine-requirejs.html#L26) it means that any UMD vendor script requires a require in order to stop require complaining about a "Mismatched anonymous define".

I don't want to put a require for that into my tests (I feel it is the pages concern to require it).

Can I suggest that you move the require definition to after the inclusion of jasmine and the vendor scripts? or else do not output vendor scripts and instead require them.. or add an option for UMD scripts that should be required in the test runner page...

@lukeapage
Copy link
Contributor Author

related maybe/kind-of a dupe of #72 (at least if #72 is solved, it fixes my problem)

@lukeapage
Copy link
Contributor Author

and solved by #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants