Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why does quote() do nothing? #178

Open
rightx2 opened this issue Jul 10, 2023 · 1 comment
Open

why does quote() do nothing? #178

rightx2 opened this issue Jul 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@rightx2
Copy link

rightx2 commented Jul 10, 2023

In ImpalaAdapter, quote() doesn't seem to do anything:

https://github.com/cloudera/dbt-impala/blob/988e6c186fbd19c086b70257b8e0c9252bb2c099/dbt/adapters/impala/impl.py#L72C2-L73C38

Any reason for this?
I have a source table of which name is reserved keyword, so there is no way to refer this table if quote() do nothing.

@rightx2
Copy link
Author

rightx2 commented Jul 10, 2023

When I set quoting: true on identifier, it raised error: Could not resolve table reference: 'mydb.nonecommentnone'(wrapped with none)

@niteshy niteshy added the bug Something isn't working label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants