Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DWX-18732 Create and delete CDW AWS cluster object #140

Merged
merged 1 commit into from
Jul 18, 2024
Merged

DWX-18732 Create and delete CDW AWS cluster object #140

merged 1 commit into from
Jul 18, 2024

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Jul 10, 2024 •
edited
Loading

This commit adds the basic creation and deletion capabilities

  • The model and schema for a data warehouse aws eks cluster creation
  • The creation call
  • The deletion call
  • Unit test coverage for creation and deletion, success and failure scenarios

vcsomor
vcsomor reviewed Jul 11, 2024
View reviewed changes
resources/dw/model_cluster.go Outdated Show resolved Hide resolved
resources/dw/model_cluster.go Outdated Show resolved Hide resolved
resources/dw/model_cluster.go Outdated Show resolved Hide resolved
resources/dw/model_cluster.go Outdated Show resolved Hide resolved
resources/dw/model_cluster.go Outdated Show resolved Hide resolved
resources/dw/resource_aws_cluster.go Outdated Show resolved Hide resolved
resources/dw/schema_cluster.go Outdated Show resolved Hide resolved
resources/dw/schema_cluster.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
examples/resources/cdp_dw_aws_cluster/resource.tf Outdated Show resolved Hide resolved
tevesz
tevesz commented Jul 15, 2024
View reviewed changes
resources/dw/model_cluster.go Outdated Show resolved Hide resolved
@tevesz tevesz force-pushed the cdp_dw_cluster_create branch 6 times, most recently from d902221 to 22eb9e1 Compare July 16, 2024 22:49
@tevesz tevesz marked this pull request as ready for review July 16, 2024 22:55
@tevesz tevesz requested a review from a team as a code owner July 16, 2024 22:55
@tevesz tevesz force-pushed the cdp_dw_cluster_create branch from 22eb9e1 to 9ba16ad Compare July 16, 2024 23:21
vcsomor
vcsomor previously approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@vcsomor vcsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits on the naming otherwise LGTM!
Thanks for the change

resources/dw/cluster/aws/model_aws_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/model_aws_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/model_aws_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/resource_aws_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/resource_aws_cluster.go Outdated Show resolved Hide resolved
resources/dw/cluster/aws/model_aws_cluster.go Outdated Show resolved Hide resolved
@tevesz tevesz force-pushed the cdp_dw_cluster_create branch 2 times, most recently from 6c11aca to 2137006 Compare July 17, 2024 13:48
gregito
gregito requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@gregito gregito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing, otherwise lgtm 🚢

examples/resources/cdp_dw_aws_cluster/resource.tf Outdated Show resolved Hide resolved
@tevesz
DWX-18732 Create and delete CDW AWS cluster object
289b315 
This commit adds the basic creation and deletion capabilities
- The model and schema for a data warehouse kubernetes cluster creation.
- The creation call
- The deletion call
- Some very basic unit tests
@tevesz tevesz force-pushed the cdp_dw_cluster_create branch from 2137006 to 289b315 Compare July 17, 2024 14:51
@gregito gregito enabled auto-merge (rebase) July 18, 2024 05:21
@gregito gregito self-requested a review July 18, 2024 07:46
@gregito gregito disabled auto-merge July 18, 2024 07:47
@tevesz tevesz merged commit 92f95cb into cloudera:main Jul 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregito gregito gregito approved these changes

@vcsomor vcsomor vcsomor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tevesz @gregito @vcsomor