Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to latest(2.x) sdk #206

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

lholmquist
Copy link
Contributor

This PR starts to update the examples in examples to use the latest released cloudevents-sdk(which is 2.x atm)

fixes #187

@lholmquist lholmquist force-pushed the 187-update-examples branch 2 times, most recently from 1105cb2 to b26b15b Compare June 4, 2020 21:09
@lholmquist lholmquist marked this pull request as ready for review June 4, 2020 21:09
@lholmquist
Copy link
Contributor Author

looks like i can't add reviewers, so @lance @helio-frota @grant

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, but otherwise LGTM. Thanks!

I think we should wait to land it though until 2.0.2.

examples/typescript-ex/src/index.ts Outdated Show resolved Hide resolved
examples/typescript-ex/src/index.ts Outdated Show resolved Hide resolved
examples/typescript-ex/src/index.ts Show resolved Hide resolved
examples/typescript-ex/src/index.ts Outdated Show resolved Hide resolved
@lance lance marked this pull request as draft June 4, 2020 21:20
@lance
Copy link
Member

lance commented Jun 4, 2020

Converted to a draft until 2.0.2 lands

@lance
Copy link
Member

lance commented Jun 4, 2020

@lholmquist you will need to modify your commits with --signoff before we can merge this (a CNCF requirement).

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist marked this pull request as ready for review June 9, 2020 17:59
@lholmquist lholmquist requested a review from lance June 9, 2020 17:59
@lholmquist
Copy link
Contributor Author

I've updated to the 2.0.2 version now

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ty!

@lance lance merged commit dcb3c4e into cloudevents:master Jun 9, 2020
@helio-frota helio-frota self-requested a review June 10, 2020 16:01
@lance lance mentioned this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples should be updated with new API
2 participants