Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ts formatter #210

Merged
merged 1 commit into from
Jun 8, 2020
Merged

feat: ts formatter #210

merged 1 commit into from
Jun 8, 2020

Conversation

grant
Copy link
Member

@grant grant commented Jun 5, 2020

Uses any for now as many types are a bit whack with the hybrid ts/js repo.

@grant grant requested a review from lance June 5, 2020 16:26
@grant grant self-assigned this Jun 5, 2020
lance
lance reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you tried all of these suggestions and they didn't work - entirely possible.

src/lib/formats/json/parser.ts Outdated Show resolved Hide resolved
src/lib/formats/json/formatter.ts Show resolved Hide resolved
src/lib/formats/json/parser.ts Outdated Show resolved Hide resolved
@grant grant force-pushed the ts branch 3 times, most recently from df98c3d to 2b0bd3a Compare June 6, 2020 19:14
@grant
Copy link
Member Author

grant commented Jun 6, 2020

DCO instructions are incorrect. :(

@grant
refactor: ts formatter
bd032d8 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
lance
lance approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grant grant merged commit 90782a9 into master Jun 8, 2020
@grant grant deleted the ts branch June 8, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

Assignees

@grant grant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @lance