feat: pass extension into the constructor. #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance
reviewed
Jun 8, 2020
There was a problem hiding this comment.
I think that the extensions should be represented in the CloudEventV1Attributes and CloudEventV03Attributes interfaces as an optional attribute. The interfaces already have a k/v property which is meant to represent the extensions, but I don't think that is correct.
lance
reviewed
Jun 9, 2020
* This allows someone to pass an extension/extensions into the CloudEvent contructor when creating a CloudEvent. fixes cloudevents#209 Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
lholmquist
force-pushed
the
209-add-extension-in-contructor
branch
from
bfa8cdd
to
768469e
Compare
|
Added an Extension interface as well as tests |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #209
Signed-off-by: Lucas Holmquist lholmqui@redhat.com