-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ref to CoC and other things #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok - just a couple of minor wording suggestions, and a question re: the CoC link.
@duglin ping - just making sure this doesn't fall off of your radar |
Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Doug Davis <dug@us.ibm.com>
thanks for the reminder @lance |
@duglin looks good to me. The title still has this as WIP. Is that the case? |
oops - fixed! |
* add ref to CoC and other things Signed-off-by: Doug Davis <dug@us.ibm.com>
* add ref to CoC and other things Signed-off-by: Doug Davis <dug@us.ibm.com>
Wait until cloudevents/spec#663 is resolved.
However, look over the wording and once we get that right I'll open similar PRs in other SDK repos
Signed-off-by: Doug Davis dug@us.ibm.com