Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Push Directly to Master #31

Closed
grant opened this issue Aug 15, 2019 · 1 comment
Closed

Don't Push Directly to Master #31

grant opened this issue Aug 15, 2019 · 1 comment

Comments

@grant
Copy link
Member

grant commented Aug 15, 2019

I don't think we're allowed to push directly to master. It seems like we must get 1 reviewer cross company.

Wanted to create a PR to convert to TS, but the library was changing too often.
See #9
CC @n3wscott
@fabiojose
Copy link
Contributor

@grant, yep! We are working with PR and reviews over that!

The library will change too often until we reach version 1.0. After that, we expect to changeless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grant @fabiojose