Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove commented version import. #319

Merged
merged 1 commit into from
Aug 19, 2020
Merged

chore: Remove commented version import. #319

merged 1 commit into from
Aug 19, 2020

Conversation

lholmquist
Copy link
Contributor

Some Small cleanup:

  • The commented out version import now gets imported from the cloudevent.ts file

@lholmquist
chore: Remove commented version import.
db6a17e 
* The commented out version import now gets imported from the cloudevent.ts file

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist requested a review from a team August 18, 2020 22:53
@lholmquist lholmquist merged commit 0adcc35 into cloudevents:main Aug 19, 2020
@lholmquist lholmquist deleted the remove-commented-version-import branch August 19, 2020 09:38
@lance lance mentioned this pull request Sep 9, 2020
Merged
lance pushed a commit that referenced this pull request Sep 11, 2020
@lholmquist @lance
chore: Remove commented version import. (#319)
ffb1a13 
* The commented out version import now gets imported from the cloudevent.ts file

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist mentioned this pull request Oct 26, 2020
Closed
@lholmquist lholmquist mentioned this pull request Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lholmquist @grant