Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README with maintainer names #337

Merged
merged 2 commits into from
Sep 9, 2020
Merged

docs: update README with maintainer names #337

merged 2 commits into from
Sep 9, 2020

Conversation

lance
Copy link
Member

@lance lance commented Sep 3, 2020

Proposed Changes

This commit changes the README to include all currently active
contributors to and the originator of the repository.

Signed-off-by: Lance Ball lball@redhat.com

@lance
docs: update README with maintainer names
3455df7 
This commit changes the README to include all currently active
contributors to and the originator of the repository.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance added the module/docs Module documentation changes label Sep 3, 2020
@lance lance requested a review from a team September 3, 2020 20:45
grant
grant approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'm not sure if Fabio has maintained this repo in the last year. Ping him?
  • @lance your name should probably be first given you're most active and probably on Slack more

Otherwise looks good

@lance
Copy link
Member Author

lance commented Sep 3, 2020

@lance your name should probably be first given you're most active and probably on Slack more

I just put them in alphabetical order by first name. I'll reach out to Fabio

@lance
fixup: remove Fabio from Slack list and put in A-Z by last name
117948e 
Signed-off-by: Lance Ball <lball@redhat.com>
@lance
Copy link
Member Author

lance commented Sep 9, 2020

@cloudevents/sdk-javascript-maintainers I have removed Fabio from the list of people to reach out to on Slack (tried pinging him on CNCF Slack with no response), and put maintainer names in alphabetical order by last name. Can I get a LGTM?

@lholmquist lholmquist self-requested a review September 9, 2020 13:31
@lance lance merged commit 0a12146 into cloudevents:main Sep 9, 2020
@lance lance deleted the update-readme branch September 9, 2020 13:45
@lholmquist lholmquist mentioned this pull request Oct 26, 2020
Closed
@lholmquist lholmquist mentioned this pull request Dec 11, 2020
Merged
This was referenced Dec 24, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

@grant grant grant approved these changes

Assignees
No one assigned
Labels
module/docs Module documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance @grant @lholmquist