Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$ref: keywords ignored in schema at path "#" #7

Closed
micheleangioni opened this issue Mar 6, 2019 · 5 comments
Closed

$ref: keywords ignored in schema at path "#" #7

micheleangioni opened this issue Mar 6, 2019 · 5 comments

Comments

@micheleangioni
Copy link
Contributor

Hi,
just requiring the sdk with a simple
const Cloudevent = require('cloudevents-sdk');

causes the following error to be shown in the console:

$ref: keywords ignored in schema at path "#"

Any suggestion or comment?

@fabiojose
Copy link
Contributor

@micheleangioni any other detail? Are you using in frontend running in the browser?

@micheleangioni
Copy link
Contributor Author

@fabiojose I am pretty sure it's related to the ajv library. I think something is wrong in the json schema definition.
However, I use it in Node.js.

@fabiojose
Copy link
Contributor

Hi @micheleangioni, according with this this is a warn message.

What do you think? In my option this is not big problem.

Should we close this?

@fabiojose fabiojose reopened this Apr 9, 2019
@micheleangioni
Copy link
Contributor Author

Hey @fabiojose , no, it's not a big problem. It's just that if all libraries emitted a warning line, an application would be flooded by warnings at startup.

What I mean it's that, even if it does not cause problems, it would be nice to remove the warning somehow. I would leave it open honestly, at least for now.

@fabiojose
Copy link
Contributor

Solve with PR #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants