chore: es6 base64 parser #75
Conversation
grant
force-pushed
the
grant_base64_parser
branch
from
f77aba2
to
2534701
Compare
| parse(payload) { | ||
| let payloadToParse = payload; | ||
| if (this.decorator) { | ||
| payloadToParse = this.decorator.parse(payload); |
There was a problem hiding this comment.
This LGTM but I don’t think the intermediary payloadToParse variable is really necessary is it? It would work just fine as
payload = this.decorator.parse(payload);There was a problem hiding this comment.
Oh, I wasn't changing any of the code functionality in the PR. Here I just renamed the variable.
There was a problem hiding this comment.
Sure - just seems that if the whole file is being changed anyway, why not make this minor optimization. Not a biggie.
There was a problem hiding this comment.
I'm just going to focus this PR and other PRs on converting this file to es6 and not changing the functionality. I'd rather do that in a different PR.
|
@grant you should rebase from |
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
grant
force-pushed
the
grant_base64_parser
branch
from
2534701
to
ca6ee6b
Compare
…rant_base64_parser
No description provided.