Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: es6 parser #98

Merged
merged 2 commits into from
Apr 30, 2020
Merged

chore: es6 parser #98

merged 2 commits into from
Apr 30, 2020

Conversation

grant
Copy link
Member

@grant grant commented Apr 30, 2020

No description provided.

@grant
chore: es6 parser
b153188 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@fabiojose fabiojose requested a review from lance April 30, 2020 15:21
@fabiojose
Copy link
Contributor

Nice, classes!
LGTM

@grant
Copy link
Member Author

grant commented Apr 30, 2020

Thanks @fabiojose, can you approve using the GitHub tool too besides the LGTM comment?

@fabiojose
Copy link
Contributor

@grant Could you fix the conflicts?

@grant
Copy link
Member Author

grant commented Apr 30, 2020

@grant Could you fix the conflicts?

What conflicts?

@grant grant merged commit cd6decd into master Apr 30, 2020
@grant grant deleted the grant_parser branch April 30, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grant @fabiojose @lance