-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify whether missing attributes should return an error
or false
#1230
Comments
This issue is stale because it has been open for 30 days with no |
@duglin could you assign this to me? |
done |
Interesting, from the spec it seems like:
IMO this seems reasonable, and would fix a lot of the problems that the current implementations have regarding errors, where it is unclear whether or not you would get an error as it depends on whether or not AND and OR are optimized to return early. @duglin @pierDipi what do you think of adding a clarification to the 3.3 Errors section that states that We could then update the tck tests to reflect this, and fix SDKs |
I agree |
Currently, when evaluating a CESQL expression with a missing attribute we return an error. However, the spec does not specify whether we should return an error or whether we should return
false
in this case. The convention of returning an error is coming from the tck tests, which have amissingAttribute
error.From conversation on slack there is a suggestion to return
false
instead of amissingAttribute
error when there is a missing attribute in a CESQL expression.Regardless of the decision to return an
error
orfalse
, the behaviour should be clarified in the spec. Hence, the scope of this issue is to:error
orfalse
should be the result of a missing attribute in a CESQL expressionThe text was updated successfully, but these errors were encountered: