Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance to not require extensions to primer #428

Closed
Tapppi opened this issue May 9, 2019 · 4 comments
Closed

Add guidance to not require extensions to primer #428

Tapppi opened this issue May 9, 2019 · 4 comments

Comments

@Tapppi
Copy link
Contributor

Tapppi commented May 9, 2019

We were about the relation between the partitionKey extension and the kafka binding on the call 09.05.2019 and there was a great snippet of someone saying that the binding should not require the extension. I think that applies on a general level and the primer should suggest that plugins/bindings/programs (what's the lowest common denominator here?) that work with CloudEvents not require extensions unless absolutely necessary.

@duglin
Copy link
Collaborator

duglin commented Jun 8, 2019

@Tapppi would you like to submit a PR?

@duglin
Copy link
Collaborator

duglin commented Jun 20, 2019

@Tapppi we added text to spec that talks about what OPTIONAL means and how people need to be prepared for cases where people ignore (or don't use) the extensions. Do you think we need more than that?

2nd para in: https://github.com/cloudevents/spec/blob/master/spec.md#notational-conventions

@duglin
Copy link
Collaborator

duglin commented Jul 1, 2021

I"m going to suggest that we close this - does anyone have any concern about this?

@jskeet
Copy link
Contributor

jskeet commented Jul 2, 2021

As a relative newcomer to the CloudEvents ecosystem, the way I read the primer and spec on extension attributes was always that they were very optional. I think how a particular binding treats an extension can easily be documented in that specific binding, and I have confidence in the review process to discourage any binding from requiring an extension unless it's clearly justified.

@duglin duglin closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants