Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible 3x improvement on addition? #23

Open
karalabe opened this issue Sep 4, 2020 · 1 comment
Open

Possible 3x improvement on addition? #23

karalabe opened this issue Sep 4, 2020 · 1 comment
Assignees
@armfazh

Comments

@karalabe
Copy link

karalabe commented Sep 4, 2020

Hey all, @Bren2010. We've received a downstream PR against go-ethereum that supposedly improves addition by a factor of 3. Would you be interested in maybe reviewing and upstreaming this PR here? ethereum/go-ethereum#21515
@karalabe karalabe mentioned this issue Sep 4, 2020
Open
@Bren2010
Copy link
Contributor

Bren2010 commented Sep 4, 2020

This optimization only helps when you need to output the final result, which I wouldn't think is a major place you're spending time. Because while you're doing your curve math, you can leave the intermediate results non-affine.

Is it the case that you're spending a lot of time outputting points? Assigning to @armfazh for more in-depth review if so

@jeffallen jeffallen mentioned this issue Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armfazh armfazh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karalabe @Bren2010 @armfazh