[Workers] (WIP) Assets #16610
Merged
[Workers] (WIP) Assets #16610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
Deploying cloudflare-docs with
|
| Latest commit: |
7d0c43d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://13f0d2fb.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://workers-assets.cloudflare-docs-7ou.pages.dev |
|
Hey hey, also since I was in there, slightly updated your PR to take advantage of built-in properties ( |
irvinebroque
reviewed
Sep 4, 2024
irvinebroque
reviewed
Sep 4, 2024
12 tasks
|
Hi @tanushree-sharma
I'm still learning about the product so feel free to ignore if this doesn't make sense. Thought I'd start with the higher-level suggestion, but feel free to ping me for more granular copyedits when needed. |
|
Thanks @ToriLindsay for the suggestion! Getting the content up and then let's play around with structure, see what flows the best. |
dcpena
reviewed
Sep 20, 2024
emily-shen
reviewed
Sep 23, 2024
src/content/docs/workers/configuration/versions-and-deployments/index.mdx
Outdated
Show resolved
Hide resolved
12 tasks
GregBrimble
force-pushed
the
workers-assets
branch
from
940164e
to
a4824cd
Compare
| args={"--type=web-framework --experimental"} | ||
| /> | ||
|
|
||
| <DirectoryListing folder="workers/frameworks/framework-guides" /> |
There was a problem hiding this comment.
fyi
docs keep looking better though
src/content/docs/workers/static-assets/compatibility-matrix.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/static-assets/compatibility-matrix.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/static-assets/compatibility-matrix.mdx
Outdated
Show resolved
Hide resolved
rita3ko
requested changes
Sep 25, 2024
GregBrimble
force-pushed
the
workers-assets
branch
from
7381353
to
51b1f63
Compare
rita3ko
approved these changes
Sep 26, 2024
GregBrimble
approved these changes
Sep 26, 2024
crwaters16
approved these changes
Sep 26, 2024
* Create C3 Frameworks component and rename Typescript to TypeScript * Rename deploy-via-c3 props * Add some framework guides for Workers Assets * Update deploy command docs * Move stuff around a bit * Final touch-ups
GregBrimble
force-pushed
the
workers-assets
branch
from
2fbbeb6
to
7329597
Compare
GregBrimble
force-pushed
the
workers-assets
branch
from
0cb2d73
to
7d0c43d
Compare
patriciasantaana
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Assets docs * Frameworks Guides (#17023) * Create C3 Frameworks component and rename Typescript to TypeScript * Rename deploy-via-c3 props * Add some framework guides for Workers Assets * Update deploy command docs * Move stuff around a bit * Final touch-ups * Hide framework guides external link * Fix a bunch of dead links * compat-matrix * content updates * vitest limitation * edits from feedback * more content updates * feedback * small fix * Greg's pass of assets docs --------- Co-authored-by: Greg Brimble <gbrimble@cloudflare.com> Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
elithrar
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Assets docs * Frameworks Guides (#17023) * Create C3 Frameworks component and rename Typescript to TypeScript * Rename deploy-via-c3 props * Add some framework guides for Workers Assets * Update deploy command docs * Move stuff around a bit * Final touch-ups * Hide framework guides external link * Fix a bunch of dead links * compat-matrix * content updates * vitest limitation * edits from feedback * more content updates * feedback * small fix * Greg's pass of assets docs --------- Co-authored-by: Greg Brimble <gbrimble@cloudflare.com> Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.