Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pointers for boolean fields in Access Applications #1006

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

Justin-Holmes
Copy link
Contributor

Description

Converts Access Application bool values to be pointers. These fields are omitted when set to false which is not the intended behavior.

Relates to: cloudflare/terraform-provider-cloudflare#1364

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

changelog detected ✅

@Justin-Holmes Justin-Holmes force-pushed the jholmes/fix-app-bools branch from 61ba72f to cd82560 Compare July 26, 2022 20:36
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #1006 (cd82560) into master (6c5ea4a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   49.06%   49.06%           
=======================================
  Files         108      108           
  Lines       10428    10428           
=======================================
  Hits         5116     5116           
  Misses       4200     4200           
  Partials     1112     1112           
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@jacobbednarz jacobbednarz merged commit 503c956 into cloudflare:master Jul 26, 2022
@github-actions github-actions bot added this to the v0.46.0 milestone Jul 26, 2022
github-actions bot pushed a commit that referenced this pull request Jul 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

This functionality has been released in v0.46.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants