-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add api shield configuration GET/PUT #1059
Conversation
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
=======================================
Coverage 49.94% 49.95%
=======================================
Files 115 116 +1
Lines 10991 11017 +26
=======================================
+ Hits 5490 5504 +14
- Misses 4338 4346 +8
- Partials 1163 1167 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Just saw https://github.com/cloudflare/cloudflare-go/blob/master/docs/experimental.md, will work to update this to follow the doc. |
Co-authored-by: Jacob Bednarz <jacob.bednarz@gmail.com>
thanks @jafowler - looks good! |
Thanks @jacobbednarz for cleaning up the tests, i'll follow that for the next few resources i'll be adding. |
This functionality has been released in v0.49.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR adds support for API shield configuration GET/PUT requests.
This is needed to help support more products under the Http Applications umbrella.
Has your change been tested?
I wrote some tests for both GET and PUT. Can add more if needed.
Types of changes
What sort of change does your code introduce/modify?
Checklist: