-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new mTLS certificate store API #1150
Add support for new mTLS certificate store API #1150
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic Private Key | 02e5fb1 | mtls_certificates_test.go | View secret |
- | Generic Private Key | 06a1da1 | mtls_certificates_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
- Coverage 50.11% 49.53% -0.58%
==========================================
Files 121 127 +6
Lines 11722 12137 +415
==========================================
+ Hits 5874 6012 +138
- Misses 4565 4758 +193
- Partials 1283 1367 +84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This functionality has been released in v0.58.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Adding mTLS cert store API endpoints to cloudflare-go in order to add mTLS cert store to Cloudflare terraform.
Has your change been tested?
Added tests for API responses.
Types of changes
What sort of change does your code introduce/modify?
Checklist: