feat(workers): allow enabling logpush on worker uploads #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re: |
|
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
- Coverage 49.40% 49.33% -0.07%
==========================================
Files 127 128 +1
Lines 12290 12408 +118
==========================================
+ Hits 6072 6122 +50
- Misses 4840 4885 +45
- Partials 1378 1401 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
workers_test.go
Outdated
Comment on lines
845
to
846
| logpush := true | ||
| res, err := client.UploadWorker(context.Background(), AccountIdentifier(testAccountID), CreateWorkerParams{ScriptName: "foo", Script: workerScript, Logpush: &logpush}) |
There was a problem hiding this comment.
Suggested change
| logpush := true | |
| res, err := client.UploadWorker(context.Background(), AccountIdentifier(testAccountID), CreateWorkerParams{ScriptName: "foo", Script: workerScript, Logpush: &logpush}) | |
| res, err := client.UploadWorker(context.Background(), AccountIdentifier(testAccountID), CreateWorkerParams{ScriptName: "foo", Script: workerScript, Logpush: BoolPtr(true)}) |
we have BoolPtr helper to simlify this sort of usage.
zebp
approved these changes
Dec 30, 2022
|
This functionality has been released in v0.58.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
ivan-section-io
pushed a commit
to section/cloudflare-go
that referenced
this pull request
Jan 12, 2023
9 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows cloudflare-go users to turn on/off logpush support for Cloudflare Workers.
The analogous functionality in Wrangler can be found here: https://github.com/cloudflare/wrangler2/blob/7169142171b1c9b4ff2f19b8b46871932ef7d10a/packages/wrangler/src/create-worker-upload-form.ts#L294
Description
This adds a new option to
CreateWorkerParamsthat allows control over the logpush setting. Note its a nullable bool: the 3 states are true - on / false - off / nil - unchanged. Again, this is analogous to wrangler with itsboolean | undefinedtype.Has your change been tested?
A new test was created to test this.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist: