Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new attr to Access App model - path_cookie_attribute #1223

Merged

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2023

Description

Adds path_cookie_attribute to Access Applications

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@ghost ghost requested a review from jacobbednarz as a code owner February 28, 2023 15:06
@ghost ghost changed the title Adds new attr to Access App model Adds new attr to Access App model - path_cookie_attribute Feb 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

hey @AkemiDavisson, can you link me to the public docs? my search fu is failing me.

@ghost
Copy link
Author

ghost commented Apr 18, 2023

hey @AkemiDavisson, can you link me to the public docs? my search fu is failing me.

Long overdue but here are the docs @jacobbednarz https://developers.cloudflare.com/api/operations/access-applications-add-an-application

I've also reopened the related TF PR: cloudflare/terraform-provider-cloudflare#2385

@jacobbednarz
Copy link
Member

thanks legend! 👏

@jacobbednarz jacobbednarz merged commit 9c3023d into cloudflare:master Apr 19, 2023
@github-actions github-actions bot added this to the v0.66.0 milestone Apr 19, 2023
github-actions bot pushed a commit that referenced this pull request Apr 19, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.66.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant