-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PA-2043 - Add support for regional hostnames #1270
PA-2043 - Add support for regional hostnames #1270
Conversation
This covers the API calls documented here: https://developers.cloudflare.com/data-localization/regional-services/get-started/
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1270 +/- ##
==========================================
- Coverage 49.23% 49.13% -0.11%
==========================================
Files 131 133 +2
Lines 12665 12994 +329
==========================================
+ Hits 6236 6384 +148
- Misses 4988 5125 +137
- Partials 1441 1485 +44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | 5d81262 | turnstile_test.go | View secret |
- | Generic High Entropy Secret | 5d81262 | turnstile_test.go | View secret |
- | Generic High Entropy Secret | 5d81262 | turnstile_test.go | View secret |
- | Generic High Entropy Secret | 5d81262 | turnstile_test.go | View secret |
- | Generic High Entropy Secret | 5d81262 | turnstile_test.go | View secret |
- | Generic High Entropy Secret | 5d81262 | turnstile_test.go | View secret |
- | Generic High Entropy Secret | 5d81262 | turnstile_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Updates the methods to have dedicated third parameters which simplifies the methods and will allow them to move independently.
9f7e095
to
f9943be
Compare
thanks @aberglund-cf! this is great 👏 |
This functionality has been released in v0.66.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Adds methods which covers the Regional Hostname API calls documented here: https://developers.cloudflare.com/data-localization/regional-services/get-started/
Has your change been tested?
Types of changes
What sort of change does your code introduce/modify?
Checklist: