Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate_packs: add Status field #1271

Merged

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Apr 21, 2023

Description

This field is essential for automating tasks related to certificate packs. For instance, upon creating a certificate pack, the validation process must be repeatedly initiated until the status transitions to active.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@cofyc cofyc requested a review from jacobbednarz as a code owner April 21, 2023 12:18
This field is essential for automating tasks related to certificate
packs. For instance, upon creating a certificate pack, the validation
process must be repeatedly initiated until the status transitions to
active.
@cofyc cofyc force-pushed the add-certificate-pack-status-field branch from 44b5ac5 to f72d69a Compare April 21, 2023 12:19
@github-actions
Copy link
Contributor

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1271 (f72d69a) into master (0c3db86) will decrease coverage by 0.14%.
The diff coverage is 40.90%.

@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   49.23%   49.10%   -0.14%     
==========================================
  Files         131      133       +2     
  Lines       12665    12987     +322     
==========================================
+ Hits         6236     6377     +141     
- Misses       4988     5125     +137     
- Partials     1441     1485      +44     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_organization.go 64.70% <ø> (ø)
access_policy.go 76.31% <ø> (ø)
certificate_packs.go 50.90% <ø> (ø)
cloudflare.go 67.28% <ø> (ø)
dns.go 45.05% <0.00%> (-28.16%) ⬇️
errors.go 40.78% <ø> (ø)
rulesets.go 34.64% <0.00%> (-0.35%) ⬇️
ssl.go 72.72% <ø> (ø)
regional_hostnames.go 36.11% <36.11%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 7041336 into cloudflare:master Apr 23, 2023
@jacobbednarz
Copy link
Member

thanks for the PR @cofyc 🙇

@github-actions github-actions bot added this to the v0.66.0 milestone Apr 23, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.66.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants