Add new Logpush fields for max upload params #1272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new Logpush fields as documented here https://developers.cloudflare.com/logs/get-started/api-configuration/#max-upload-parameters
max_upload_bytes
max_upload_records
max_upload_interval_seconds
The new fields do have server side validation around the integer values, I wasn't sure whether this client should perform the same validation. Opted out for now as I assume the client doesn't want to be tied into values that could easily change in Cloudflares API.
Similarly,
max_upload_bytes
andmax_upload_records
cannot be used ifkind
is set toedge
, not sure if that's validation that should be done in the client or not?Has your change been tested?
Added to existing logpush tests
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist: