logpush: modernise methods #1326
Merged
+374
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
jacobbednarz
force-pushed
the
modernise-logpush
branch
from
49a7990 to
e1c2ff5
Compare
Updates the logpush methods to: - Use the newer client method signatures - Remove the duplicate internal methods for account/zone level methods in favour of using `*ResourceContainer` - Stop using `AccessIdentifiers` This introduces a bit more duplication in the `Create`/`Update` methods however it does allow us to handle creation and updates separately explicitly instead of bunching all the logic into a single method with conditionals.
jacobbednarz
force-pushed
the
modernise-logpush
branch
from
e1c2ff5 to
0a58e18
Compare
Codecov Report
@@ Coverage Diff @@
## master #1326 +/- ##
==========================================
- Coverage 48.33% 48.33% -0.01%
==========================================
Files 133 133
Lines 13023 13038 +15
==========================================
+ Hits 6295 6302 +7
- Misses 5201 5207 +6
- Partials 1527 1529 +2
|
|
This functionality has been released in v0.72.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the logpush methods to:
for account/zone level methods in favour of using
*ResourceContainerAccessIdentifiersThis introduces a bit more duplication in the
Create/Updatemethods howeverit does allow us to handle creation and updates separately explicitly instead
of bunching all the logic into a single method with conditionals.