Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ServeError action and http_custom_errors phase #998

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

kroosec
Copy link
Contributor

@kroosec kroosec commented Jul 19, 2022

Add support for the new http_custom_errors phase, that uses the serve_error action. This action supports action parameters content, content_type and status_code.

@kroosec kroosec requested a review from jacobbednarz as a code owner July 19, 2022 22:39
@kroosec kroosec force-pushed the custom-errors-support branch from 72fdb5c to c82958b Compare July 19, 2022 23:59
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #998 (f52af54) into master (401e1c1) will increase coverage by 0.12%.
The diff coverage is 70.51%.

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
+ Coverage   48.93%   49.06%   +0.12%     
==========================================
  Files         108      108              
  Lines       10385    10428      +43     
==========================================
+ Hits         5082     5116      +34     
- Misses       4195     4200       +5     
- Partials     1108     1112       +4     
Impacted Files Coverage Δ
rulesets.go 27.65% <0.00%> (-0.30%) ⬇️
firewall_rules.go 52.58% <71.05%> (+3.62%) ⬆️
filter.go 42.44% <73.68%> (+5.15%) ⬆️
pagination.go 71.42% <0.00%> (+71.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just pending public docs and we can merge this one.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2022

changelog detected ✅

@kroosec kroosec force-pushed the custom-errors-support branch from 6d2cf99 to 5d0a12b Compare July 21, 2022 08:52
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2022

changelog detected ✅

@kroosec kroosec force-pushed the custom-errors-support branch from 5d0a12b to f52af54 Compare July 21, 2022 23:04
.changelog/998.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit cf9190b into cloudflare:master Jul 22, 2022
@github-actions github-actions bot added this to the v0.46.0 milestone Jul 22, 2022
github-actions bot pushed a commit that referenced this pull request Jul 22, 2022
@jacobbednarz
Copy link
Member

public docs will be released early next week.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

This functionality has been released in v0.46.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants