Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support [text_blobs] #211

Closed
mrbbot opened this issue Mar 8, 2022 · 3 comments
Closed

Support [text_blobs] #211

mrbbot opened this issue Mar 8, 2022 · 3 comments
Labels
new api Unsupported new Workers runtime API
Milestone
2.4.0

Comments

@mrbbot
Copy link
Contributor

mrbbot commented Mar 8, 2022

Wrangler allows text bindings to be loaded from files. Miniflare should support these too.

[text_blobs]
TEXT = "./text.txt"

See cloudflare/workers-sdk#518 and cloudflare/wrangler-legacy#1543.
@mrbbot mrbbot added the new api Unsupported new Workers runtime API label Mar 8, 2022
@mrbbot mrbbot added this to the 2.4.0 milestone Mar 8, 2022
@threepointone
Copy link
Contributor

Oh ha, I thought miniflare already supported this. I didn't even know about wasm_modules/text_blobs until recently 😅

This was referenced Mar 9, 2022
Closed
Closed
@caass caass mentioned this issue Mar 30, 2022
Merged
@mrbbot
Copy link
Contributor Author

mrbbot commented Mar 30, 2022

Added in #228 🎉

@mrbbot mrbbot closed this as completed Mar 30, 2022
@threepointone
Copy link
Contributor

Amazing, thank you! I'll update miniflare in w2 as soon as you have a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new api Unsupported new Workers runtime API
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@threepointone @mrbbot