Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition between delete / put for unawaited mutations #344

Closed
vlovich opened this issue Aug 22, 2022 · 0 comments
Closed

Race condition between delete / put for unawaited mutations #344

vlovich opened this issue Aug 22, 2022 · 0 comments
Labels
behaviour mismatch Different behaviour to Workers runtime bug Something isn't working

Comments

@vlovich
Copy link
Contributor

vlovich commented Aug 22, 2022

Potentially related to #250, unawaited mutations (put/delete) can race each other even though it can't in the real runtime.

export class Durable {
    constructor(state) {
        this.state = state
    }

    async fetch(request) {
        await this.state.storage.transaction((txn) => {
            void txn.delete('foo')
            void txn.put('foo', 'value')
        })
        return new Response(await this.state.storage.get('foo') ?? 'undefined')
    }
}

export default {
  async fetch(request, env, runtime) {
    const stub = env.DURABLE.get(env.DURABLE.idFromName('some object'))
    return stub.fetch(request)
  }
}
@mrbbot mrbbot closed this as completed in 5361d60 Aug 22, 2022
@mrbbot mrbbot added bug Something isn't working behaviour mismatch Different behaviour to Workers runtime labels Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviour mismatch Different behaviour to Workers runtime bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants