Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildPlugin: fix build.watch_dir to allow passing in array #557

Merged
merged 2 commits into from
May 5, 2023

Conversation

sj-e2digital
Copy link
Contributor

@sj-e2digital sj-e2digital commented Apr 16, 2023

Align Miniflare behaviour with wrangler.toml functionality (see https://developers.cloudflare.com/workers/wrangler/configuration/#custom-builds watch_dir).

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2023

⚠️ No Changeset found

Latest commit: 1ae9de2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sj-e2digital sj-e2digital changed the title build watch dir array BuildPlugin: fix build.watch_dir to allow passing in array Apr 16, 2023
@sj-e2digital sj-e2digital force-pushed the build-watch-dir-array branch from e80b49e to 8e7ee2b Compare April 16, 2023 11:54
@mrbbot mrbbot force-pushed the build-watch-dir-array branch from 8e7ee2b to 1ae9de2 Compare May 5, 2023 00:07
@mrbbot
Copy link
Contributor

mrbbot commented May 5, 2023

Hey! 👋 Thanks for the PR! Just rebasing this on some recent changes, which should fix the CI failure. 👍

@mrbbot mrbbot merged commit afe731c into cloudflare:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants