Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk based development and differentiating preview vs production env #114

Open
nader-eloshaiker opened this issue Jan 15, 2024 · 0 comments

Comments

@nader-eloshaiker
Copy link

I have recently switched my repo to trunk based where by I only have a main branch and features/fixes/chores go straight into it. Further, using google-github-actions/release-please-action, I use PR's to perform the releasing process. So stagging/preview and production deployments are done from the main branch.
The my workflows are able to differentiate when to deploy to preview and production using the branch property in cloudflare/pages-action and it seems to work well. I use the value branch: stagging for feature merges and branch: main for production.
However, what I have noticed in GitHub and in google-github-actions/release-please-action source code, is that the GitHub environment will always be production and not preview due to the fact that they both work off main despite the value of branch passed to the action.

@nader-eloshaiker nader-eloshaiker changed the title Trank based development and differentiating preview vs production env Trunk based development and differentiating preview vs production env Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant