Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dist folder to improve performance #61

Closed
wants to merge 2 commits into from
Closed

Use dist folder to improve performance #61

wants to merge 2 commits into from

Conversation

ari-becker
Copy link

Fixes #60

@ari-becker ari-becker requested a review from a team as a code owner February 15, 2023 14:23
@ari-becker
Copy link
Author

Never mind, I see the real reason is due to shellac making a shell call to npx to invoke wrangler. This prevents wrangler from being cached by GitHub Actions.

@ari-becker ari-becker closed this Mar 1, 2023
@ari-becker ari-becker deleted the use-dist-folder branch March 1, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor performance because wrangler is not cached or in-lined
1 participant
@ari-becker