Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to prevent a large amount of body content from piling up in the buffer when h2 is sending data? #500

Open
zhangqiang-01 opened this issue Dec 31, 2024 · 2 comments
Assignees
Labels
Performance Performance of efficiency.

Comments

@zhangqiang-01
Copy link

What is the problem your feature solves, or the need it fulfills?

I've noticed that in the write_body function of h2, the data to be sent is simply added to the sending queue. If data sending gets blocked, will it lead to a large amount of data piling up and an inaccurate situation of send_bytes statistics?

@zhangqiang-01
Copy link
Author

Should we first use poll_capacity to wait until the buffer is sufficient before send_data?

@eaufavor eaufavor added the Performance Performance of efficiency. label Jan 3, 2025
@eaufavor eaufavor self-assigned this Jan 3, 2025
@eaufavor
Copy link
Member

eaufavor commented Jan 3, 2025

I'm working on a fix as you suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Performance of efficiency.
Projects
None yet
Development

No branches or pull requests

2 participants