Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promql/series: expose lookback as config variable #493

Closed
fbs opened this issue Jan 8, 2023 · 2 comments · Fixed by #498
Closed

promql/series: expose lookback as config variable #493

fbs opened this issue Jan 8, 2023 · 2 comments · Fixed by #498

Comments

@fbs
Copy link
Contributor

fbs commented Jan 8, 2023

I have a thanos setup where prometheus only has 2 days worth of data. The older data has to be accessed through a thanos endpoint and alert rules over longer time periods have to be be placed on the ruler.

The lookback period is currently hard coded to 7 days but as there is no data there is no point in going back that far. The amount of queries it has to do to cover 7 days, multiple testcases and multiple series per rule also do add up, and it might cause incorrect output as well.

I'd like to see the lookback period exposed as config option, e.g.

check "promql/series" {
  lookbackPeriod = "6h"
}

How do you feel about this?

I already implemented something but the contribution guide recommended to open an issue before opening a PR :)

@prymitive
Copy link
Collaborator

Fixed via #498

@fbs
Copy link
Contributor Author

fbs commented Jan 11, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants