Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclude option to ci config #609

Closed
wbollock opened this issue Apr 20, 2023 · 0 comments · Fixed by #641
Closed

Add exclude option to ci config #609

wbollock opened this issue Apr 20, 2023 · 0 comments · Fixed by #641
Assignees
@prymitive

Comments

@wbollock
Copy link

Similar to the Prometheus block, ci could use an exclude config option that takes precedence over include:

pint/internal/config/prometheus.go

Line 32 in 948facf

Exclude []string `hcl:"exclude,optional" json:"exclude,omitempty"`

And anywhere else that has include could use an exclude. It's a useful option. I'd be happy to contribute this but wanted to make an issue first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prymitive prymitive

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add exclude option to ci block cloudflare/pint
2 participants
@prymitive @wbollock