Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teams list and device posture rule resources #1058

Conversation

Justin-Holmes
Copy link
Contributor

No description provided.

@Justin-Holmes Justin-Holmes changed the title Add teams list and device posture rule resources [WIP] Add teams list and device posture rule resources May 11, 2021
@Justin-Holmes Justin-Holmes changed the title [WIP] Add teams list and device posture rule resources Add teams list and device posture rule resources May 11, 2021
@Justin-Holmes Justin-Holmes force-pushed the jholmes/teams-lists-and-device-posture-rules branch 6 times, most recently from fb72f5c to 883b9b5 Compare May 20, 2021 20:43
@Justin-Holmes Justin-Holmes marked this pull request as ready for review May 20, 2021 20:43
@Justin-Holmes Justin-Holmes force-pushed the jholmes/teams-lists-and-device-posture-rules branch from 883b9b5 to 430e3e4 Compare May 20, 2021 21:17
@jacobbednarz
Copy link
Member

@Justin-Holmes are we able to drop the dependency upgrades here please? we generally bump them outside of the PRs and then just update the PRs to prevent conflicts (which it looks like we have here).

@Justin-Holmes Justin-Holmes force-pushed the jholmes/teams-lists-and-device-posture-rules branch from 430e3e4 to 5b0f375 Compare May 21, 2021 13:47
@Justin-Holmes
Copy link
Contributor Author

@jacobbednarz Are those linter errors a concern? I'm happy to fix them if so.

@jacobbednarz
Copy link
Member

Yeah, they are worth while listening to. They generally catch hard to debug issues (like type incompatibilites in the schema) which commonly silently fail.

@Justin-Holmes Justin-Holmes force-pushed the jholmes/teams-lists-and-device-posture-rules branch from 5b0f375 to 7877c20 Compare May 21, 2021 22:14
@Justin-Holmes
Copy link
Contributor Author

@jacobbednarz Alright, should be fixed!

@jacobbednarz jacobbednarz force-pushed the jholmes/teams-lists-and-device-posture-rules branch from 7877c20 to 5096adf Compare May 23, 2021 21:46
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of small nitpicks but we're nearly there!

@jacobbednarz
Copy link
Member

noice! 👏

@jacobbednarz jacobbednarz merged commit a00d862 into cloudflare:master May 26, 2021
@Justin-Holmes Justin-Holmes deleted the jholmes/teams-lists-and-device-posture-rules branch May 26, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants