Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser_cache_ttl setting doesn't work #107

Closed
sixcorners opened this issue Aug 20, 2018 · 4 comments · Fixed by #291
Closed

browser_cache_ttl setting doesn't work #107

sixcorners opened this issue Aug 20, 2018 · 4 comments · Fixed by #291
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@sixcorners
Copy link

sixcorners commented Aug 20, 2018

Hi there,

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

Terraform Version

Terraform v0.11.8

  • provider.cloudflare v1.2.0

Affected Resource(s)

  • cloudflare_zone_settings_override.settings

Terraform Configuration Files

resource "cloudflare_zone_settings_override" "settings" {
  name = "${var.cloudflare_zone}"

  settings {
    browser_cache_ttl = 0
  }
}

Debug Output

https://gist.github.com/sixcorners/31d365e40d7aa20dec7f7d812c09d6b6

Expected Behavior

What should have happened?
browser_cache_ttl should have been set to 0.

Actual Behavior

What actually happened?
browser_cache_ttl didn't change.

Steps to Reproduce

  1. terraform state rm cloudflare_zone_settings_override.settings && terraform apply

Important Factoids

References

@patryk patryk added the kind/bug Categorizes issue or PR as related to a bug. label Aug 31, 2018
@patryk patryk closed this as completed in c179204 Sep 3, 2018
@patryk
Copy link
Contributor

patryk commented Sep 4, 2018

Hey @sixcorners, the issue will be fixed in v1.3.0.

@garrettgalow
Copy link
Contributor

This doesn't appear to be fixed in the latest version:

cloudflare_page_rule.cf_test_Browser_cache: Modifying... (ID: a1c9307ff4dd125f8b50ecd4a23f6c04)
  actions.0.browser_cache_ttl: "0" => "10"
cloudflare_page_rule.cf_test_Browser_cache: Modifications complete after 0s (ID: a1c9307ff4dd125f8b50ecd4a23f6c04)

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.
some_tf_example$ terraform apply
cloudflare_page_rule.cf_test_Browser_cache: Refreshing state... (ID: a1c9307ff4dd125f8b50ecd4a23f6c04)

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.
some_tf_example$ vim cloudflare.tf
some_tf_example$ terraform apply
cloudflare_page_rule.cf_test_Browser_cache: Refreshing state... (ID: a1c9307ff4dd125f8b50ecd4a23f6c04)

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ cloudflare_page_rule.cf_test_Browser_cache
      actions.0.browser_cache_ttl: "10" => "0"


Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

cloudflare_page_rule.cf_test_Browser_cache: Modifying... (ID: a1c9307ff4dd125f8b50ecd4a23f6c04)
  actions.0.browser_cache_ttl: "10" => "0"
cloudflare_page_rule.cf_test_Browser_cache: Modifications complete after 0s (ID: a1c9307ff4dd125f8b50ecd4a23f6c04)

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.
some_tf_example$ terraform apply
cloudflare_page_rule.cf_test_Browser_cache: Refreshing state... (ID: a1c9307ff4dd125f8b50ecd4a23f6c04)

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ cloudflare_page_rule.cf_test_Browser_cache
      actions.0.browser_cache_ttl: "10" => "0"


Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: no


Error: Apply cancelled.

@garrettgalow
Copy link
Contributor

made value 10 then tried to set to 0. it 'succeeded' but the value remains 10

@patryk patryk reopened this Apr 11, 2019
@patryk
Copy link
Contributor

patryk commented Apr 12, 2019

@garrettgalow you're reporting the issue in Page Rules (which is different from zone settings override), although this one also needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants